Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove cargo audit --ignore RUSTSEC-2022-0093 #12465

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: remove cargo audit --ignore RUSTSEC-2022-0093 #12465

merged 1 commit into from
Sep 21, 2023

Conversation

yufansong
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

For issue #11986, it is solved at #12227 . So remove the cargo audit specific ignore.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Sep 20, 2023
@yufansong yufansong requested a review from wenym1 September 20, 2023 18:24
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #12465 (5aed644) into main (7cb3903) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 59.45%.

@@            Coverage Diff             @@
##             main   #12465      +/-   ##
==========================================
- Coverage   69.65%   69.65%   -0.01%     
==========================================
  Files        1424     1425       +1     
  Lines      236438   236469      +31     
==========================================
+ Hits       164702   164720      +18     
- Misses      71736    71749      +13
Flag Coverage Δ
rust 69.65% <59.45%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/expr/src/expr/expr_array_transform.rs 0.00% <0.00%> (ø)
src/expr/src/expr/expr_some_all.rs 0.00% <0.00%> (ø)
src/expr/src/expr/expr_udf.rs 0.00% <0.00%> (ø)
src/expr/src/expr/value.rs 0.00% <0.00%> (ø)
src/expr/src/table_function/user_defined.rs 0.00% <ø> (ø)
src/expr/src/expr/mod.rs 58.82% <66.66%> (-1.18%) ⬇️
src/expr/src/expr/wrapper/checked.rs 70.00% <70.00%> (ø)
src/expr/macro/src/gen.rs 96.98% <100.00%> (ø)
src/expr/src/expr/build.rs 80.92% <100.00%> (+0.78%) ⬆️
src/expr/src/expr/expr_binary_nullable.rs 97.26% <100.00%> (ø)
... and 4 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yufansong yufansong added this pull request to the merge queue Sep 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 21, 2023
@yufansong yufansong added this pull request to the merge queue Sep 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 21, 2023
@yufansong yufansong added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 6d0b56d Sep 21, 2023
@yufansong yufansong deleted the yufan/fix-audit branch September 21, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenym1 wenym1 wenym1 approved these changes

Assignees
No one assigned
Labels
type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yufansong @wenym1